NT-2133:UI β Misaligned icon on error messages #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1335 +/- ##
=========================================
Coverage 74.18% 74.18%
Complexity 743 743
=========================================
Files 221 221
Lines 6667 6667
Branches 407 407
=========================================
Hits 4946 4946
Misses 1584 1584
Partials 137 137 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π² What
Icon alignment follows the design β both for errors when loading more root comments and more replies
π€ Why
To match Figma design
π How
separate button and icon
π See
device-2021-07-26-200838.mp4
π QA
Test both for Initial /Pagination errors when loading more root comments and more replies
Story π
https://kickstarter.atlassian.net/browse/NT-2133