Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2161:UI – Not-a-backer-anymore taking the space of the original comment #1342

Merged
merged 6 commits into from
Aug 3, 2021

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Jul 30, 2021

πŸ“² What

Remove Not-a-backer-anymore comments are currently extra whitespace
image

πŸ›  How

  1. Make comment body gone
  2. add gone margin

πŸ‘€ See

device-2021-07-30-211256.mp4

πŸ“‹ QA

Instructions for anyone to be able to QA this work.

Story πŸ“–

https://kickstarter.atlassian.net/browse/NT-2161

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1342 (9f25428) into master (d9e6734) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1342   +/-   ##
=========================================
  Coverage     74.16%   74.16%           
  Complexity      743      743           
=========================================
  Files           221      221           
  Lines          6669     6669           
  Branches        409      409           
=========================================
  Hits           4946     4946           
  Misses         1584     1584           
  Partials        139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update d9e6734...9f25428. Read the comment docs.

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! πŸŽ‰

@hadia hadia merged commit 3e70dcf into master Aug 3, 2021
@hadia hadia deleted the hadia/NT-2161-UI–Not-a-backer branch August 3, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants