[NT-2171]: Position of item on ViewHolder #1354

Arkariang · 2021-08-10T23:17:29Z

📲 What

Retrieved the position of the item via getAbsoluteAdapterPosition
No need to modify the bindData(data: Any?) as we have available the previously mentioned function
There was a duplicated CommentExt I gather together the comment extension in just one.
Modified extension methods
Comment.updateCommentAfterSuccessfulPost and fun Comment.updateCommentFailedToPost to receive as parameter the position to update in the comment list.
The callback fun onCommentPostedSuccessFully(comment: Comment) and fun onCommentPostedFailed(comment: Comment) now get the position as parameter as well.

🤔 Why

To avoid any search on the comments list for the specific comment, the callbacks are given now the position of that item on the recyclerView.

🛠 How

Using getAbsoluteAdapterPosition

👀 See

No user facing changes
| | |

📋 QA

Try the to post comments without internet to have the error state on RootComments and Threads, everything should work as usual.

Story 📖

NT-2171

… ThreadActivity

… and the ThreadActivity" This reverts commit fe0aecc.

…Post extensions to receive the position to update the comment

…tin/NT-2171-send-position-to-viewHolder * 'master' of github.com:kickstarter/android-oss: NT-2012:Finalize the Adoption of View Bindings (#1351)

… method getAbsoluteAdapterPosition

codecov · 2021-08-10T23:28:28Z

Codecov Report

Merging #1354 (ba6bdd2) into master (3b083a4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1354   +/-   ##
=========================================
  Coverage     74.16%   74.16%           
  Complexity      743      743           
=========================================
  Files           221      221           
  Lines          6669     6669           
  Branches        409      409           
=========================================
  Hits           4946     4946           
  Misses         1584     1584           
  Partials        139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b083a4...ba6bdd2. Read the comment docs.

hadia

Approved

Arkariang · 2021-08-11T18:03:31Z

app/src/main/java/com/kickstarter/ui/viewholders/CommentCardViewHolder.kt

@@ -111,12 +111,12 @@ class CommentCardViewHolder(
        this.vm.outputs.isSuccessfullyPosted()
            .compose(bindToLifecycle())
            .compose(Transformers.observeForUI())
-            .subscribe { this.delegate.onCommentPostedSuccessFully(it) }
+            .subscribe { this.delegate.onCommentPostedSuccessFully(it, absoluteAdapterPosition) }


documentation around absoluteAdapterPosition method

…tin/prepare-for-arctic-fox * 'master' of github.com:kickstarter/android-oss: [NT-2171]: Position of item on ViewHolder (#1354) Fix shipping isssue (#1356) NT-2178 :💥 – Posting comment on update (#1355) [no-jira]: remove 3 random failing screenshot test (#1359)

(cherry picked from commit 3449c33)

hadia added 30 commits August 2, 2021 21:35

Refactor account activity

f9aa382

Refactor Login activity

68ee87a

Merge branch 'master' into hadia/Finalize_the_Adoption_of_View_Bindings

5f7b94e

UpdateActivity refactor

c66b243

EditProfileActivity refactor

33a1c9d

update activity refactor

459fa6f

SettingsActivity refactor

6cea1ae

ProfileActivity.kt refactor

3766a0a

ProfileActivity.kt refactor

b4b8489

ResetPasswordActivity refactor

e35e59a

ChangePasswordActivity refactor

cba7da2

ChangePasswordActivity remove comment

f41eaa1

ChangeEmailActivity.kt refactor to view binding

24b0179

PrivacyActivity refactor to view binding

2066e6e

PrivacyActivity refactor to view binding

baa7e97

CampaignDetailsActivity refactor to view binding

3f68d80

MessageCreatorActivity.kt refactor to view binding

98f3c79

PaymentMethodsSettingsActivity.kt refactor to view binding

60a948e

NotificationsActivity.kt refactor to view binding

11472ba

NewsletterActivity.kt refactor to view binding

df6349c

CreatorBioActivity.kt refactor to view binding

79fde0a

CreatePasswordActivity.kt refactor to view binding

1eeac5b

EditorialActivity.kt refactor to view binding

afaa675

ProjectActivity.kt refactor to view binding

825b93e

updata ProjectActivity.kt refactor to view binding

ccd5546

RewardsFragment.kt refactor to view binding

c3cf0c1

update RewardsFragment.kt refactor to view binding

781d102

Merge branch 'master' into hadia/Finalize_the_Adoption_of_View_Bindings

2158e96

refactor BackingAddOnsFragment to use viewBinding

85323d1

refactor CancelPledgeFragment.kt to use viewBinding

f6ca323

hadia and others added 12 commits August 9, 2021 18:13

Fix change mail issue

48a827b

Fix Shipping rule

8b01965

- Added position parameter to the bindData function

8c7a877

- linters

8eb247f

- Refatored to send the position back to the CommentsActivity and the…

fe0aecc

… ThreadActivity

Revert "- Refatored to send the position back to the CommentsActivity…

8858495

… and the ThreadActivity" This reverts commit fe0aecc.

Refactored updateCommentAfterSuccessfulPost and updateCommentFailedTo…

de6068e

…Post extensions to receive the position to update the comment

Merge branch 'master' of github.com:kickstarter/android-oss into imar…

b3f9ad7

…tin/NT-2171-send-position-to-viewHolder * 'master' of github.com:kickstarter/android-oss: NT-2012:Finalize the Adoption of View Bindings (#1351)

- Tests

f5286ef

- send absoluteAdapterPosition to the callback position

6be98ed

- linter

0387454

- undo the bindData function, as we should use instead the viewHolder…

92aa754

… method getAbsoluteAdapterPosition

hadia approved these changes Aug 11, 2021

View reviewed changes

Arkariang requested a review from hadia August 11, 2021 17:45

Merge branch 'master' into imartin/NT-2171-send-position-to-viewHolder

e9ed818

Arkariang changed the title ~~Imartin/nt 2171 send position to view holder~~ [NT-2171]: Position of item on ViewHolder Aug 11, 2021

Arkariang commented Aug 11, 2021

View reviewed changes

Arkariang marked this pull request as ready for review August 11, 2021 18:20

Arkariang requested a review from leighdouglas August 11, 2021 18:21

Arkariang added maintenance 🗜 refactor 🛠 labels Aug 11, 2021

Arkariang and others added 4 commits August 11, 2021 13:48

Merge branch 'master' into imartin/NT-2171-send-position-to-viewHolder

e0a0e6b

Merge branch 'master' into imartin/NT-2171-send-position-to-viewHolder

6585421

Merge branch 'master' into imartin/NT-2171-send-position-to-viewHolder

f8ed41f

Merge branch 'master' into imartin/NT-2171-send-position-to-viewHolder

ba6bdd2

Arkariang merged commit 3449c33 into master Aug 12, 2021

Arkariang deleted the imartin/NT-2171-send-position-to-viewHolder branch August 12, 2021 15:48

Arkariang added a commit that referenced this pull request Aug 16, 2021

[NT-2171]: Position of item on ViewHolder (#1354)

e65ab47

(cherry picked from commit 3449c33)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NT-2171]: Position of item on ViewHolder #1354

[NT-2171]: Position of item on ViewHolder #1354

Arkariang commented Aug 10, 2021 •

edited

codecov bot commented Aug 10, 2021 •

edited

hadia left a comment

Arkariang Aug 11, 2021 •

edited

[NT-2171]: Position of item on ViewHolder #1354

[NT-2171]: Position of item on ViewHolder #1354

Conversation

Arkariang commented Aug 10, 2021 • edited

📲 What

🤔 Why

🛠 How

👀 See

📋 QA

Story 📖

codecov bot commented Aug 10, 2021 • edited

Codecov Report

hadia left a comment

Choose a reason for hiding this comment

Arkariang Aug 11, 2021 • edited

Choose a reason for hiding this comment

Arkariang commented Aug 10, 2021 •

edited

codecov bot commented Aug 10, 2021 •

edited

Arkariang Aug 11, 2021 •

edited