Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2162: Remove comments feature flags #1367

Merged
merged 7 commits into from Aug 19, 2021

Conversation

Arkariang
Copy link
Contributor

馃摬 What

  • Remove all the feature flags related to comments from the source code
  • Remove all deprecated code related to the old comments screen
  • Remove all the deprecated code related to comments and the V1 API client

馃憖 See

  • No user facing changes
    | | |

馃搵 QA

  • Test you can see root comments
  • Test you can see thread comments
  • Test you can see the reply button and view replies button only on the root comments screen.
  • Test same scenarios as before in updates

Story 馃摉

NT-2162

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #1367 (33bad71) into master (141f94e) will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1367      +/-   ##
============================================
- Coverage     74.16%   73.63%   -0.54%     
+ Complexity      743      733      -10     
============================================
  Files           221      213       -8     
  Lines          6669     6428     -241     
  Branches        409      400       -9     
============================================
- Hits           4946     4733     -213     
+ Misses         1584     1556      -28     
  Partials        139      139              
Impacted Files Coverage 螖
...com/kickstarter/ui/adapters/data/CommentsData.java 0.00% <酶> (-100.00%) 猬囷笍
...va/com/kickstarter/viewmodels/UpdateViewModel.java 95.34% <酶> (-0.36%) 猬囷笍
...c/main/java/com/kickstarter/libs/ApiPaginator.java 77.01% <0.00%> (-3.45%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 141f94e...33bad71. Read the comment docs.

@Arkariang Arkariang requested review from leighdouglas and hadia and removed request for leighdouglas August 18, 2021 17:23
@Arkariang Arkariang marked this pull request as ready for review August 18, 2021 17:28
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀

@Arkariang Arkariang merged commit fbf34a0 into master Aug 19, 2021
@Arkariang Arkariang deleted the imartin/NT-2162-remove-comments-feature-flags branch August 19, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants