Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-4123: Addon card component with fixed missing description #1369

Merged
merged 15 commits into from Aug 20, 2021

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Aug 19, 2021

馃摬 What

  • Updated this to fix the broken description disappearing on addons that should have it

馃洜 How

Screen Shot 2021-08-19 at 10 26 55 AM

馃憖 See

馃搵 QA

  • Go to the project GURLZ - An artbook by Serge Birault
  • Navigate to project addons
  • Description should be visible

Story 馃摉

NT-2143: Refactor the AddOns screen to use the re-usable components

@leighdouglas leighdouglas force-pushed the leigh/nt-4122-addon-card-component branch from a29cf34 to 0c0e79e Compare August 19, 2021 15:31
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #1369 (c9eebde) into master (df5476c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1369   +/-   ##
=========================================
  Coverage     73.63%   73.63%           
  Complexity      733      733           
=========================================
  Files           213      213           
  Lines          6428     6428           
  Branches        400      400           
=========================================
  Hits           4733     4733           
  Misses         1556     1556           
  Partials        139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update df5476c...c9eebde. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@leighdouglas leighdouglas merged commit 9f11530 into master Aug 20, 2021
@leighdouglas leighdouglas deleted the leigh/nt-4122-addon-card-component branch August 20, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants