Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2193: Braze push notifications #1374

Merged
merged 5 commits into from Aug 20, 2021
Merged

NT-2193: Braze push notifications #1374

merged 5 commits into from Aug 20, 2021

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Aug 19, 2021

馃摬 What

  • Update braze version
  • Force initialize for braze client.

馃憖 See

brazeWorking.mp4

| | |

馃搵 QA

  • as in the video

Story 馃摉

NT-2193

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #1374 (1f8da94) into master (ee6f537) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1374      +/-   ##
============================================
+ Coverage     73.63%   73.66%   +0.03%     
- Complexity      733      736       +3     
============================================
  Files           213      213              
  Lines          6428     6428              
  Branches        400      400              
============================================
+ Hits           4733     4735       +2     
+ Misses         1556     1553       -3     
- Partials        139      140       +1     
Impacted Files Coverage 螖
app/src/main/java/com/kickstarter/libs/Build.java 75.00% <0.00%> (+12.50%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ee6f537...1f8da94. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review August 19, 2021 21:51
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀馃槏

@@ -309,7 +309,7 @@ dependencies {

// Analytics Segment-Braze
implementation 'com.segment.analytics.android:analytics:4.9.4'
implementation 'com.appboy:appboy-segment-integration:8.0.2'
implementation 'com.appboy:appboy-segment-integration:9.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that one of the issues in android 12 solved

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憦馃徑

@Arkariang Arkariang merged commit 6ba2c54 into master Aug 20, 2021
@Arkariang Arkariang deleted the imartin/Braze-9.0.0 branch August 20, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants