Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2142: Addon card shot test #1375

Merged
merged 4 commits into from Aug 20, 2021
Merged

Conversation

leighdouglas
Copy link
Contributor

馃摬 What

Shot tests for add-on card reusable component.

馃憖 See

Screen Shot 2021-08-19 at 11 38 32 AM

馃搵 QA

  • The tests have been recorded using an emulator Pixel 3a on API 30, I'll suggest use the same device or the size of the screenshot may change
  • Execute ./gradlew executeScreenshotTests it will run the tests and do the comparison between the recorded screenshots and the ones running.

Story 馃摉

NT-2142: Addon card shot tests

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #1375 (f11babb) into master (9f11530) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1375   +/-   ##
=========================================
  Coverage     73.63%   73.63%           
  Complexity      733      733           
=========================================
  Files           213      213           
  Lines          6428     6428           
  Branches        400      400           
=========================================
  Hits           4733     4733           
  Misses         1556     1556           
  Partials        139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9f11530...f11babb. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Great work @leighdouglas :)
    I executed it on my environemnt and works perfectly as in CI , 馃憤

@leighdouglas leighdouglas merged commit 6fb9677 into master Aug 20, 2021
@leighdouglas leighdouglas deleted the leigh/nt-2142-addon-card-shot-test branch August 20, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants