[NTV-174 & NTV-175]: fetch faq & environmentCommitment from GraphQL #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- call to deprecated methods updated
…kstarter/android-oss into imartin/ntv-191-rewards-missing-fields * 'feature/NTV-181-project-from-graphql' of github.com:kickstarter/android-oss: NTV-182: missing values v1 Currency + No Reward (#1391)
…kstarter/android-oss into imartin/ntv-173-faq-environment-risks * 'feature/NTV-181-project-from-graphql' of github.com:kickstarter/android-oss: NTV-191: rewards missing fields (#1393)
- model - tranformer method - tests
Codecov Report
@@ Coverage Diff @@
## master #1400 +/- ##
=========================================
Coverage 72.22% 72.22%
Complexity 739 739
=========================================
Files 211 211
Lines 6071 6071
Branches 391 391
=========================================
Hits 4385 4385
Misses 1549 1549
Partials 137 137
Continue to review full report at Codecov.
|
| @@ -1169,11 +1158,13 @@ private fun projectTransformer(projectFragment: FullProject?): Project { | |||
| .staticUsdRate(staticUSDRate) | |||
| .usdExchangeRate(usdExchangeRate) | |||
| .updatedAt(updatedAt) | |||
| // .unreadMessagesCount() TODO: unread messages can be fetched form the User Object | |||
| // .unseenActivityCount() TODO: unseen activity can be fetched form the User Object | |||
| // .unreadMessagesCount() unread messages can be fetched form the User Object | |||
There was a problem hiding this comment.
Nit: Do we need this commented out code? If not we should remove it, unless it's providing context.
There was a problem hiding this comment.
It's for providing context, as those fields have value when fetched from V1, but on GraphQL they do not exist under Project
Base automatically changed from
feature/NTV-181-project-from-graphql
to
master
September 20, 2021 17:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
🛠 How
fullProjectfragmentProjectFaqnew model createdEnvironmentalCommitmentnew model createdProject.javamodel has two new fields :projectFaqs: List<ProjectFaq>, .envCommitments: List<EnvironmentalCommitment>👀 See
| | |
📋 QA
ℹ️ We should start moving all the transformer private methods inside
KSApolloClientinto the new fileGraphQLTransformers.ktto be tested 😄 let me know if any concern/doubts on itProjectViewModelon the currentproject observable and map the two new fields :)Story 📖
NTV-174
NTV-175