Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No-Jira]: Remove unnecessary network call #1402

Merged
merged 4 commits into from Sep 21, 2021

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Before adding the project query, we were getting project information from V1, and backing information from GraphQL
  • Now that the entire project is fetched from GraphQL we added to the project query the backing query as well, making redundant the call to apolloClient.getProjectBacking as the information is already on the Project
  • Added initialization for two fields for project model
  • Exchanged flatmap over switchmap operator

🛠 How

  • Remove network call to fetch backing information as it's already included in the project query.

👀 See

  • No visible user facing changes, improvements on the reduction of networking calls
    | | |

📋 QA

  • Back a project.
  • Load several previously backed project, and view your pledge
  • View your pledge from a message

- added initializer for two fields on project page.
…ndroid-oss into imartin/small-improvements

* 'imartin/small-improvements' of github.com:kickstarter/android-oss:
  Regression 2.19.0 (#1396)
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #1402 (d9c2daf) into master (c6bb045) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1402   +/-   ##
=========================================
  Coverage     72.19%   72.19%           
  Complexity      738      738           
=========================================
  Files           211      211           
  Lines          6071     6071           
  Branches        391      391           
=========================================
  Hits           4383     4383           
  Misses         1550     1550           
  Partials        138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6bb045...d9c2daf. Read the comment docs.

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀 🤖

@Arkariang Arkariang merged commit c417945 into master Sep 21, 2021
@Arkariang Arkariang deleted the imartin/small-improvements branch September 21, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants