Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-203: Project Page v2 Feature Flag #1414

Merged
merged 21 commits into from Sep 29, 2021
Merged

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Sep 29, 2021

📲 What

Created a new optimizely feature flag named android_project_page_v2 and added it to the codebase to split the new and old designs.

🛠 How

Added a boolean value to the viewmodel outputs where we are calling to open the project page that represents if the feature flag is enabled.
This is passed to an Intent extension function that returns an intent with the appropriate project activity:

Screen Shot 2021-09-29 at 11 43 13 AM

👀 See

Example of the pledging flow from the discover screen:

project.page.v2.ff.pledging.flow.mp4

📋 QA

Test the project page flow in staging for all of these locations:

  1. ActivityFeedActivity
    -- Manage pledge clicks
    -- Project clicks
  2. Creator Dashboard
    -- Project button
  3. Discovery
    -- Project card clicks
    -- Activity Sample Project Click
  4. Push Notifications
  5. Profile page
  6. Search page
  7. Thanks page
  8. Update page

🐝 Please note that I was unable to test push notifications or the creator dashboard 🐝

I did not add the feature flag to the DeeplinkViewModel.

Story 📖

NTV-203: Optimizely Feature Flag

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! as soon as the java linter is fixed feel free to merge!

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #1414 (0d4f1ae) into master (d472757) will increase coverage by 0.03%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1414      +/-   ##
============================================
+ Coverage     72.20%   72.23%   +0.03%     
  Complexity      738      738              
============================================
  Files           211      211              
  Lines          6072     6084      +12     
  Branches        391      391              
============================================
+ Hits           4384     4395      +11     
- Misses         1550     1551       +1     
  Partials        138      138              
Impacted Files Coverage Δ
...n/java/com/kickstarter/libs/PushNotifications.java 5.80% <40.00%> (+0.36%) ⬆️
...wmodels/CreatorDashboardHeaderHolderViewModel.java 98.73% <100.00%> (+0.06%) ⬆️
...va/com/kickstarter/viewmodels/SearchViewModel.java 96.49% <100.00%> (+0.09%) ⬆️
...va/com/kickstarter/viewmodels/ThanksViewModel.java 98.21% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d472757...0d4f1ae. Read the comment docs.

@Arkariang Arkariang merged commit 38bb841 into master Sep 29, 2021
@Arkariang Arkariang deleted the leigh/ntv-203-project-page-ff branch September 29, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants