New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTV-203: Project Page v2 Feature Flag #1414
Conversation
5bc2710
to
7b146bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! as soon as the java linter is fixed feel free to merge!
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
============================================
+ Coverage 72.20% 72.23% +0.03%
Complexity 738 738
============================================
Files 211 211
Lines 6072 6084 +12
Branches 391 391
============================================
+ Hits 4384 4395 +11
- Misses 1550 1551 +1
Partials 138 138
Continue to review full report at Codecov.
|
📲 What
Created a new optimizely feature flag named
android_project_page_v2
and added it to the codebase to split the new and old designs.🛠 How
Added a boolean value to the viewmodel outputs where we are calling to open the project page that represents if the feature flag is enabled.
This is passed to an Intent extension function that returns an intent with the appropriate project activity:
👀 See
Example of the pledging flow from the discover screen:
project.page.v2.ff.pledging.flow.mp4
📋 QA
Test the project page flow in staging for all of these locations:
-- Manage pledge clicks
-- Project clicks
-- Project button
-- Project card clicks
-- Activity Sample Project Click
🐝 Please note that I was unable to test push notifications or the creator dashboard 🐝
I did not add the feature flag to the DeeplinkViewModel.
Story 📖
NTV-203: Optimizely Feature Flag