NTV-235:Ask a question #1419
Merged
NTV-235:Ask a question #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1419 +/- ##
=========================================
Coverage 72.24% 72.24%
Complexity 738 738
=========================================
Files 211 211
Lines 6085 6085
Branches 391 391
=========================================
Hits 4396 4396
Misses 1551 1551
Partials 138 138 Continue to review full report at Codecov.
|
Arkariang
reviewed
Oct 7, 2021
| private fun setupRecyclerView() { | ||
| binding?.fqaRecyclerView?.adapter = fqaAdapter | ||
| requireContext().getDrawable(R.drawable.divider_grey_300_horizontal)?.let { |
There was a problem hiding this comment.
you can substitute
requireContext().getDrawable(R.drawable.divider_grey_300_horizontal)
over
ResourcesCompat.getDrawable(resources, R.drawable.divider_grey_300_horizontal, null)
and remove the SuppressLint rule on line 110
Arkariang
approved these changes
Oct 7, 2021
Arkariang
added a commit
that referenced
this pull request
Oct 7, 2021
…tin/NTV-207-project-overview * 'master' of github.com:kickstarter/android-oss: NTV-235:Ask a question (#1419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
ask the creator a question from the FAQ tab
🛠 How
-Add "SimpleDividerItemDecoration class
👀 See
device-2021-10-07-164545.mp4
📋 QA
Story 📖
https://kickstarter.atlassian.net/browse/NTV-235