Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-228: Reward fulfilled deeplink #1422

Merged
merged 12 commits into from Oct 20, 2021
Merged

NTV-228: Reward fulfilled deeplink #1422

merged 12 commits into from Oct 20, 2021

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Oct 13, 2021

📲 What

  • Added a new deeplink
  • Small refactor

👀 See

fulfilled

DeepLinkFromInAppMessage.mp4

| | |

📋 QA

  • You can either launch an In-app message from braze, - you can use the test campaign and just update the deeplink link.
  • Or use send an email to yourself with a link with format like https://staging.kickstarter.com/projects/polymernai/baby-spirits-plush-collection/mark_reward_fulfilled/true if you choose this last case you won't see the Discovery activity but if after pressing the deeplink you navigate until the backed project you should see the checkbox marked.

Story 📖

NTV-228

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1422 (1bb8072) into master (ff7e402) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1422   +/-   ##
=========================================
  Coverage     72.27%   72.27%           
  Complexity      739      739           
=========================================
  Files           211      211           
  Lines          6085     6085           
  Branches        391      391           
=========================================
  Hits           4398     4398           
  Misses         1549     1549           
  Partials        138      138           
Impacted Files Coverage Δ
.../src/main/java/com/kickstarter/models/Project.java 63.49% <ø> (ø)
...kstarter/ui/intentmappers/ProjectIntentMapper.java 89.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7e402...1bb8072. Read the comment docs.

@Arkariang Arkariang changed the title NTV-228: https://kickstarter.atlassian.net/browse/NTV-228 NTV-228: Reward fulfilled deeplink Oct 14, 2021
@Arkariang Arkariang closed this Oct 14, 2021
@Arkariang Arkariang deleted the imartin/NTV-228 branch October 14, 2021 19:42
@Arkariang Arkariang restored the imartin/NTV-228 branch October 15, 2021 23:23
@Arkariang Arkariang reopened this Oct 15, 2021
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@Arkariang Arkariang merged commit 43459e2 into master Oct 20, 2021
@Arkariang Arkariang deleted the imartin/NTV-228 branch October 20, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants