Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-239 :Add Segment events to tabs #1434

Merged
merged 3 commits into from Oct 27, 2021

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Oct 27, 2021

馃摬 What

Add Page Viewed events to each tab selection

馃 Why

track user tabs selections

馃洜 How

Add the selection when tab selected
image

馃憖 See

image
image
image

馃搵 QA

Open project change tab selection and compare with segment

Story 馃摉

https://kickstarter.atlassian.net/browse/NTV-239

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1434 (c79f80f) into master (3269d6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1434   +/-   ##
=========================================
  Coverage     72.28%   72.28%           
  Complexity      738      738           
=========================================
  Files           211      211           
  Lines          6084     6084           
  Branches        391      391           
=========================================
  Hits           4398     4398           
  Misses         1548     1548           
  Partials        138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3269d6e...c79f80f. Read the comment docs.

@hadia hadia merged commit ff10283 into master Oct 27, 2021
@hadia hadia deleted the hadia/NTV-239_Add_Segment_events_to_tabs branch October 27, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants