Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the null value for project when clicked heart button #1436

Merged
merged 1 commit into from Oct 29, 2021

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Oct 29, 2021

📲 What

Fix the crash when clicking the heart icon on the project page

🤔 Why

we call that service to save the project and update the UI with returned project object which has a different structure than the original graph-ql as environment Commits return null

🛠 How

Filter value that is not null

👀 See

device-2021-10-29-182612.mp4

📋 QA

Open project page with tabs and click Heart ❤️ icon

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #1436 (da67e1b) into master (ff10283) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1436   +/-   ##
=========================================
  Coverage     72.28%   72.28%           
  Complexity      738      738           
=========================================
  Files           211      211           
  Lines          6084     6084           
  Branches        391      391           
=========================================
  Hits           4398     4398           
  Misses         1548     1548           
  Partials        138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff10283...da67e1b. Read the comment docs.

@hadia hadia merged commit 936ad65 into master Oct 29, 2021
@hadia hadia deleted the hadia/fix_crash_when_heart_icon_clicked branch October 29, 2021 17:24
Arkariang added a commit that referenced this pull request Oct 29, 2021
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-215:project collaborator can't comment on project in mobile (#1437)
  Filter the null value for project when clicked heart button (#1436)

# Conflicts:
#	app/src/main/java/com/kickstarter/services/KSApolloClient.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants