Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTV-276: Polish Project screen loading experience #1450

Merged
merged 2 commits into from Nov 8, 2021
Merged

NTV-276: Polish Project screen loading experience #1450

merged 2 commits into from Nov 8, 2021

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Added placeholder for project image, to avoid resizing jumps on the project page

🤔 Why

  • improve user experience

👀 See

placeholder.mp4

| | |

📋 QA

  • Load several project, you'll see no jumps on the internal content as there is no resizing going on for the media header image.

Story 📖

NTV-276

@codecov
Copy link

codecov bot commented Nov 6, 2021 •
edited

Codecov Report

Merging #1450 (dd1c685) into master (01c8117) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1450   +/-   ##
=========================================
  Coverage     72.29%   72.29%           
  Complexity      736      736           
=========================================
  Files           210      210           
  Lines          6082     6082           
  Branches        391      391           
=========================================
  Hits           4397     4397           
  Misses         1547     1547           
  Partials        138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c8117...dd1c685. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review November 6, 2021 00:15
hadia
hadia approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Arkariang Arkariang merged commit eb655b5 into master Nov 8, 2021
@Arkariang Arkariang deleted the imartin/NTV-276-loading-experience-video branch November 8, 2021 17:17
Arkariang added a commit that referenced this pull request Nov 8, 2021
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into imar…
42424b1 
…tin/NTV-270-image-parsing

* 'master' of github.com:kickstarter/android-oss:
  NTV-276: Polish Project screen loading experience (#1450)
Arkariang added a commit that referenced this pull request Nov 10, 2021
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into feat…
d68fbac 
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-276: Polish Project screen loading experience (#1450)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadia hadia hadia approved these changes

@leighdouglas leighdouglas Awaiting requested review from leighdouglas

Assignees
No one assigned
Labels
UI 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkariang @hadia