Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-261 :Fetch and apply new translations #1465

Merged
merged 2 commits into from Nov 24, 2021
Merged

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Nov 23, 2021

📲 What

Fix the styling for the Ask a question button!
image

Fix nested scroll effect for recycler view
https://kickstarter.slack.com/archives/CG55BBBBL/p1637693032010500

👀 See

device-2021-11-23-215710.mp4

📋 QA

Check FQA and different scrollable areas "The LMNL Tent System by Diamond Brand"
Check to ask question button style

Story 📖

https://kickstarter.atlassian.net/browse/NTV-261

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #1465 (9bbbe4e) into master (65f049e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1465   +/-   ##
=========================================
  Coverage     72.69%   72.69%           
  Complexity      711      711           
=========================================
  Files           209      209           
  Lines          6031     6031           
  Branches        375      375           
=========================================
  Hits           4384     4384           
  Misses         1512     1512           
  Partials        135      135           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f049e...9bbbe4e. Read the comment docs.

@hadia hadia merged commit a651e4f into master Nov 24, 2021
@hadia hadia deleted the hadia/fix_project_page_ui branch November 24, 2021 16:41
Arkariang added a commit that referenced this pull request Nov 24, 2021
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-261 :Fetch and apply new translations (#1465)
Arkariang added a commit that referenced this pull request Nov 24, 2021
…r/android-oss into imartin/NTV-267-TextElementsUI

* 'feature/NTV-188-Project-Story' of github.com:kickstarter/android-oss:
  NTV-261 :Fetch and apply new translations (#1465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants