no-jira: flaky tests related to DateTime.now #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
=========================================
Coverage 72.69% 72.69%
Complexity 711 711
=========================================
Files 209 209
Lines 6031 6031
Branches 375 375
=========================================
Hits 4384 4384
Misses 1512 1512
Partials 135 135 Continue to review full report at Codecov.
|
hadia
approved these changes
Dec 8, 2021
Arkariang
added a commit
that referenced
this pull request
Dec 8, 2021
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: no-jira: flaky tests related to DateTime.now() (#1478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
deadlineCountdownValue()depending on when was executed will fail the test for the deadline countdown.🤔 Why
👀 See
com.kickstarter.libs.utils.extensions.ProjectExtTest#testDeadlineCountdownValue_testAllCases_shouldReturnCorrectValueOfTime, should no longer fail some times| | |
📋 QA