Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTV-333: RewardItems, Item Models #1503

Merged
merged 6 commits into from Jan 10, 2022
Merged

NTV-333: RewardItems, Item Models #1503

merged 6 commits into from Jan 10, 2022

Conversation

Arkariang
Copy link
Contributor

📲 What

🤔 Why

  • Remove all references to AutoParcel library in Models, eventually we will be able to remove that dependency.

👀 See

  • No user facing changes

| | |

📋 QA

  • Load rewars with items, load addons with items from several projects.
  • Pledge to some of them.
  • Review your pledge.

Story 📖

NTV-333

@Arkariang Arkariang added migration Migration Java to Kotlin maintenance 🗜 labels Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022 •
edited

Codecov Report

Merging #1503 (0d82919) into master (4789381) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1503      +/-   ##
============================================
- Coverage     72.17%   72.07%   -0.11%     
+ Complexity      597      591       -6     
============================================
  Files           193      189       -4     
  Lines          5584     5564      -20     
  Branches        308      308              
============================================
- Hits           4030     4010      -20     
  Misses         1465     1465              
  Partials         89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4789381...0d82919. Read the comment docs.

leighdouglas
leighdouglas approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@Arkariang Arkariang merged commit 17065ad into master Jan 10, 2022
@Arkariang Arkariang deleted the imartin/NTV-333-reward-items branch January 10, 2022 16:49
Arkariang added a commit that referenced this pull request Jan 10, 2022
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into feat…
5121674 
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-333: RewardItems, Item Models (#1503)
  NTV-332: Category Model (#1502)
  NTV-274: User model  (#1500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@hadia hadia Awaiting requested review from hadia

Assignees
No one assigned
Labels
maintenance 🗜 migration Migration Java to Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkariang @leighdouglas