NTV-53:Viewing comment thread #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1514 +/- ##
=========================================
Coverage 69.33% 69.33%
Complexity 453 453
=========================================
Files 178 178
Lines 4817 4817
Branches 285 285
=========================================
Hits 3340 3340
Misses 1397 1397
Partials 80 80 Continue to review full report at Codecov.
|
# Conflicts: # app/src/main/java/com/kickstarter/libs/AnalyticEvents.kt
Arkariang
added a commit
that referenced
this pull request
Jan 18, 2022
…tin/NTV-339-spike * 'master' of github.com:kickstarter/android-oss: NTV-53:Viewing comment thread (#1514)
Arkariang
added a commit
that referenced
this pull request
Jan 19, 2022
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: Add comment_root_id to post comments (#1518) NTV-339: getProjects from GraphQL queries (#1516) NTV-53 :Viewing /Posting comment thread (#1517) NTV-351 Segment – Add project_url to properties (#1515) NTV-53:Viewing comment thread (#1514) # Conflicts: # app/src/main/java/com/kickstarter/services/KSApolloClient.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Add Segment event when loading thread comments on:
🤔 Why
In order to keep track of comments usage
🛠 How
👀 See
📋 QA
open thread comments for the project and update and check the segment events
For testing deep link
adb shell am start -a android.intent.action.VIEW -c android.intent.category.BROWSABLE -d "https://staging.kickstarter.com/projects/fjorden/fjorden-iphone-photography-reinvented/comments?comment=Q29tbWVudC0zMzY0OTg0MQ%3D%3D"Story 📖
[Name of Trello Story](Trello link)