Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-379 : Migrate Config.java to kotlin and deprecate Autoparcel #1568

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 17, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

device-2022-03-18-170101.mp4

📋 QA

  • Launch the app Kickstarter and check user configuration

Story 📖

https://kickstarter.atlassian.net/browse/NTV-379

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1568 (3d1910d) into master (cbcc183) will increase coverage by 0.10%.
The diff coverage is 93.83%.

@@             Coverage Diff              @@
##             master    #1568      +/-   ##
============================================
+ Coverage     76.25%   76.35%   +0.10%     
- Complexity     1529     1538       +9     
============================================
  Files           355      355              
  Lines         14561    14640      +79     
  Branches       1633     1642       +9     
============================================
+ Hits          11104    11179      +75     
+ Misses         2596     2590       -6     
- Partials        861      871      +10     
Impacted Files Coverage Δ
...ckstarter/libs/utils/extensions/ConfigExtension.kt 56.75% <80.00%> (+5.24%) ⬆️
app/src/main/java/com/kickstarter/libs/Config.kt 90.47% <90.47%> (ø)
...va/com/kickstarter/mock/factories/ConfigFactory.kt 100.00% <100.00%> (ø)
...com/kickstarter/libs/AutoParcelAdapterFactory.java 27.27% <0.00%> (-54.55%) ⬇️
...om/kickstarter/libs/utils/extensions/ProjectExt.kt 74.68% <0.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbcc183...3d1910d. Read the comment docs.

@hadia hadia marked this pull request as ready for review March 18, 2022 15:02
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changing currency as well.
great work @hadia!

@hadia hadia merged commit 17c8ac1 into master Mar 22, 2022
@hadia hadia deleted the hadia/NTV-379_Migrate_Config.java_to_kotlin_and_deprecate_Autoparcel branch March 22, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants