Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-482 :Migrate MessageThreadEnvelope.java and MessageThreadsEnvelope.java t… #1595

Merged
merged 4 commits into from Apr 11, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Apr 7, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

Uploading device-2022-04-07-195252.mp4…

📋 QA

Test Message thread for user

Story 📖

https://kickstarter.atlassian.net/browse/NTV-481
https://kickstarter.atlassian.net/browse/NTV-482

@hadia hadia added maintenance 🗜 migration Migration Java to Kotlin labels Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1595 (e817b8f) into master (4dda18b) will increase coverage by 0.10%.
The diff coverage is 95.72%.

@@             Coverage Diff              @@
##             master    #1595      +/-   ##
============================================
+ Coverage     77.57%   77.67%   +0.10%     
- Complexity     1672     1684      +12     
============================================
  Files           356      356              
  Lines         15267    15355      +88     
  Branches       1721     1730       +9     
============================================
+ Hits          11843    11927      +84     
  Misses         2502     2502              
- Partials        922      926       +4     
Impacted Files Coverage Δ
...er/services/apiresponses/MessageThreadsEnvelope.kt 93.84% <93.84%> (ø)
...ter/services/apiresponses/MessageThreadEnvelope.kt 96.96% <96.96%> (ø)
...ter/mock/factories/MessageThreadEnvelopeFactory.kt 100.00% <100.00%> (ø)
...er/mock/factories/MessageThreadsEnvelopeFactory.kt 100.00% <100.00%> (ø)
.../main/java/com/kickstarter/models/MessageThread.kt 91.80% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dda18b...e817b8f. Read the comment docs.

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hadia hadia merged commit 38777b1 into master Apr 11, 2022
@hadia hadia deleted the hadia/NTV-482 branch April 11, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance 🗜 migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants