Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTV-489 :Migrate NavigationDrawerData.java to kotlin and deprecate Autoparcel #1604

Merged
merged 4 commits into from Apr 15, 2022
Merged

NTV-489 :Migrate NavigationDrawerData.java to kotlin and deprecate Autoparcel #1604

merged 4 commits into from Apr 15, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Apr 14, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

device-2022-04-14-170153.mp4

📋 QA

test NavigationDrawer

Story 📖

https://kickstarter.atlassian.net/browse/NTV-489

@hadia hadia added maintenance 🗜 migration Migration Java to Kotlin labels Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022 •
edited

Codecov Report

Merging #1604 (2aad153) into master (150c67e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1604   +/-   ##
=========================================
  Coverage     77.80%   77.80%           
  Complexity     1739     1739           
=========================================
  Files           356      356           
  Lines         15640    15640           
  Branches       1801     1801           
=========================================
  Hits          12168    12168           
  Misses         2505     2505           
  Partials        967      967
Impacted Files Coverage Δ
...src/main/java/com/kickstarter/models/StoredCard.kt 94.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150c67e...2aad153. Read the comment docs.

leighdouglas
leighdouglas approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Tested navigation drawer and everything is working 🎉 🚀

@hadia hadia merged commit e3cd393 into master Apr 15, 2022
@hadia hadia deleted the hadia/NTV-489 branch April 15, 2022 21:43
Arkariang added a commit that referenced this pull request Apr 18, 2022
@Arkariang
Merge branch 'imartin/ntv-530' of github.com:kickstarter/android-oss …
aa7a5f4 
…into imartin/ntv-530

* 'imartin/ntv-530' of github.com:kickstarter/android-oss:
  NTV-478  Migrate CategoriesEnvelope.java to kotlin and deprecate Autoparcel (#1605)
  NTV-489 :Migrate NavigationDrawerData.java to kotlin and deprecate Autoparcel (#1604)
Arkariang added a commit that referenced this pull request Apr 18, 2022
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into imar…
d0afe4d 
…tin/pay-1420-migrate-to-graph

* 'master' of github.com:kickstarter/android-oss:
  NTV-478  Migrate CategoriesEnvelope.java to kotlin and deprecate Autoparcel (#1605)
  NTV-489 :Migrate NavigationDrawerData.java to kotlin and deprecate Autoparcel (#1604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkariang Arkariang Arkariang approved these changes

@leighdouglas leighdouglas leighdouglas approved these changes

Assignees
No one assigned
Labels
maintenance 🗜 migration Migration Java to Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hadia @Arkariang @leighdouglas