NTV-569 : Migrate Signin/Login related classes to kotlin

[hadia]

📲 What

Migrate classes from java to kotlin

1. LoginReason
2. LoginToutViewModel
3. SignupViewModel
4. TwoFactorViewModel
5. LoginPopupMenu

🤔 Why

Migrate All classes to java.

📋 QA

test Message Sign/Sigup 2FA

Story 📖

https://kickstarter.atlassian.net/browse/NTV-569

[codecov]

Codecov Report

Merging #1651 (ead5219) into master (e09c5d2) will decrease coverage by 0.06%.
The diff coverage is 86.62%.

@@             Coverage Diff              @@
##             master    #1651      +/-   ##
============================================
- Coverage     78.40%   78.33%   -0.07%     
+ Complexity     1864     1863       -1     
============================================
  Files           353      353              
  Lines         16728    16739      +11     
  Branches       2085     2098      +13     
============================================
- Hits          13115    13113       -2     
  Misses         2408     2408              
- Partials       1205     1218      +13     

Impacted Files	Coverage Δ
...a/com/kickstarter/viewmodels/LoginToutViewModel.kt	75.43% <75.43%> (ø)
...c/main/java/com/kickstarter/ui/data/LoginReason.kt	81.81% <81.81%> (ø)
...a/com/kickstarter/viewmodels/TwoFactorViewModel.kt	93.51% <93.51%> (ø)
...java/com/kickstarter/viewmodels/SignupViewModel.kt	93.82% <93.82%> (ø)
...pp/src/main/java/com/kickstarter/models/Message.kt	79.16% <0.00%> (-2.09%)	⬇️
...src/main/java/com/kickstarter/models/StoredCard.kt	94.91% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09c5d2...ead5219. Read the comment docs.

[leighdouglas]

Noticed there are a bunch of codecov warnings here, should these be covered by tests? Is this a codecov error related to the other issues we've been having with it?

[hadia]

I am not sure how to test Facebook callbacks @Arkariang any suggestions

[Arkariang]

For being able to properly test those callbacks we should've created a wrapper client around FacebookSDK (Dependency Inversion Principle, as we do for Apollo, Retrofit, or Braze -> DIP, that implementation it's out of the scope of this task for sure.
FYI I think there were some conversations around deprecating Facebook as login method, but nothing conclusive yet, so it's ok for now to not have coverage on those areas yet.

[leighdouglas]

Left a comment about code coverage on one particular view model, otherwise tested on staging and prod and everything is working as it should! 🚀