Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-575 : Migrate SurveyHolderViewModel/SurveyResponseViewModel related classes to kotlin #1655

Merged
merged 4 commits into from Jul 18, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Jul 18, 2022

📲 What

Migrate classes from java to kotlin

  1. SurveyHolderViewModel
  2. SurveyResponseViewModel

🤔 Why

Migrate All classes to java.

📋 QA

test Survey screen using the native account

device-2022-07-18-160518.mp4

Story 📖

https://kickstarter.atlassian.net/browse/NTV-575

@hadia hadia added the migration Migration Java to Kotlin label Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #1655 (d3ec454) into master (ca47d91) will decrease coverage by 0.00%.
The diff coverage is 94.02%.

@@             Coverage Diff              @@
##             master    #1655      +/-   ##
============================================
- Coverage     78.41%   78.40%   -0.01%     
  Complexity     1868     1868              
============================================
  Files           353      353              
  Lines         16740    16748       +8     
  Branches       2098     2101       +3     
============================================
+ Hits          13126    13131       +5     
  Misses         2397     2397              
- Partials       1217     1220       +3     
Impacted Files Coverage Δ
...om/kickstarter/viewmodels/SurveyHolderViewModel.kt 92.59% <92.59%> (ø)
.../kickstarter/viewmodels/SurveyResponseViewModel.kt 95.00% <95.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca47d91...d3ec454. Read the comment docs.

@hadia hadia merged commit b919c8a into master Jul 18, 2022
@hadia hadia deleted the hadia/NTV-575 branch July 18, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants