Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-587: Segment event for campaign tab #1663

Merged
merged 1 commit into from Jul 25, 2022
Merged

NTV-587: Segment event for campaign tab #1663

merged 1 commit into from Jul 25, 2022

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Jul 25, 2022

馃摬 What

  • When the user hits the Campaign tab, an analytic events should be sent to segment with the format:
    Event type: Page Viewed
    context_page: project
    context_section: campaign

馃洜 How

  • The code was already in place, sending incorrect context_section

馃憖 See

  • Logcat screenshot

Screen Shot 2022-07-25 at 10 09 44 AM

  • Segment debugger

Screen Shot 2022-07-25 at 10 13 25 AM

| | |

馃搵 QA

  • Take a look in logcat when hitting the campaign tab, make sure the event is triggered with the correct properties.
  • Take a look at Segment debugger, event should be there.

Story 馃摉

NTV-587

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌 lgtm!

@Arkariang Arkariang merged commit e92e70b into master Jul 25, 2022
@Arkariang Arkariang deleted the imartin/NTV-587 branch July 25, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants