Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-1764: Update UI with for payment method using PaymentSheet #1666

Merged
merged 10 commits into from Jul 28, 2022

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Jul 27, 2022

📲 What

  • Using stripe's PaymentSheet, when the user completes adding a new card, we obtain some information back, that allows us to update the UI with the card logo resourceID and the lats for digits.
  • ℹ️ Note the expiration data is not available.
  • ⚠️ not able to pledge yet selecting the payment methods added via paymentsheet

🤔 Why

  • Update the UI with the new card

🛠 How

  • Extend the model StoreCard to hold the new information.

👀 See

newPaymentMethodUI.mp4

| | |

📋 QA

  • Add a new payment method on pledge screen with the feature flag off -> old path with will load PledgeFragmentLegacy
  • Add a new payment method on pledge screen with the feature flag on, and deviceID added to the feature flag audience -> new path it will load PledgeFragment

Story 📖

https://kickstarter.atlassian.net/browse/PAY-1764

@Arkariang Arkariang marked this pull request as ready for review July 27, 2022 18:12
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1666 (f371ca2) into master (d57353a) will decrease coverage by 0.00%.
The diff coverage is 84.31%.

❗ Current head f371ca2 differs from pull request most recent head 0b07971. Consider uploading reports for the commit 0b07971 to get more accurate results

@@             Coverage Diff              @@
##             master    #1666      +/-   ##
============================================
- Coverage     78.45%   78.44%   -0.01%     
- Complexity     1872     1875       +3     
============================================
  Files           354      355       +1     
  Lines         16793    16820      +27     
  Branches       2112     2119       +7     
============================================
+ Hits          13175    13195      +20     
  Misses         2390     2390              
- Partials       1228     1235       +7     
Impacted Files Coverage Δ
...om/kickstarter/libs/utils/extensions/ProjectExt.kt 70.88% <0.00%> (-1.27%) ⬇️
...com/kickstarter/models/extensions/StoredCardExt.kt 78.94% <78.94%> (ø)
...src/main/java/com/kickstarter/models/StoredCard.kt 91.93% <88.46%> (-2.98%) ⬇️
...om/kickstarter/mock/factories/StoredCardFactory.kt 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Arkariang Arkariang merged commit 373d957 into master Jul 28, 2022
@Arkariang Arkariang deleted the imartin/PAY-1764 branch July 28, 2022 15:40
Arkariang added a commit that referenced this pull request Aug 10, 2022
…ure/Android_13_Support

* 'master' of github.com:kickstarter/android-oss:
  PAY-1814: Loading states  (#1670)
  [no-jira]: Fix the null pointer exception for BackingFragment (#1671)
  WEB-688 :[Android ]Forget Password screen back few times (#1672)
  PAY-1789: Complete a pledge using PaymentSheet (#1668)
  WEB-678:[Android] Create feature flag for Facebook login deprecation. (#1667)
  - update versions
  PAY-1764: Update UI with for payment method using PaymentSheet (#1666)
  WEB-622: Translations for comment moderation + reworking hyperlink logic (#1665)
  NTV-583 : Migrate ProjectSearchResultHolderViewModel related classes to kotlin (#1662)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants