New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAY-1764: Update UI with for payment method using PaymentSheet #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
============================================
- Coverage 78.45% 78.44% -0.01%
- Complexity 1872 1875 +3
============================================
Files 354 355 +1
Lines 16793 16820 +27
Branches 2112 2119 +7
============================================
+ Hits 13175 13195 +20
Misses 2390 2390
- Partials 1228 1235 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Arkariang
added a commit
that referenced
this pull request
Aug 10, 2022
…ure/Android_13_Support * 'master' of github.com:kickstarter/android-oss: PAY-1814: Loading states (#1670) [no-jira]: Fix the null pointer exception for BackingFragment (#1671) WEB-688 :[Android ]Forget Password screen back few times (#1672) PAY-1789: Complete a pledge using PaymentSheet (#1668) WEB-678:[Android] Create feature flag for Facebook login deprecation. (#1667) - update versions PAY-1764: Update UI with for payment method using PaymentSheet (#1666) WEB-622: Translations for comment moderation + reworking hyperlink logic (#1665) NTV-583 : Migrate ProjectSearchResultHolderViewModel related classes to kotlin (#1662)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
PaymentSheet
, when the user completes adding a new card, we obtain some information back, that allows us to update the UI with the card logo resourceID and the lats for digits.🤔 Why
🛠 How
StoreCard
to hold the new information.👀 See
newPaymentMethodUI.mp4
| | |
📋 QA
PledgeFragmentLegacy
PledgeFragment
Story 📖
https://kickstarter.atlassian.net/browse/PAY-1764