Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-622: Internal builds not being generated #1690

Merged
merged 7 commits into from Sep 26, 2022
Merged

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Sep 26, 2022

馃摬 What

Take a look into the internal pipelines -> https://app.circleci.com/pipelines/github/kickstarter/android-private
Take a look into the external pipelines (Open source repository) -> https://app.circleci.com/pipelines/github/kickstarter/android-oss

The internal ones where failing due to a time out on the code coverage generation

馃洜 How

  • Updated the orbs for Android and codecov
  • Deleted redundant step for testing, executing jacocoExternalReleaseReport set will call internally testExternalRelease

馃憖 See

馃搵 QA

  • Nothing to QA, it's CI integration step, once this PR is merged the internal builds should run perfectly, but in case you wanna test it checkout this branch, raname it to 'internal' and push to the private repository, it will trigger the job for generating internal builds

Story 馃摉

NTV-622

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Arkariang Arkariang merged commit a0a6511 into master Sep 26, 2022
@Arkariang Arkariang deleted the imartin/NTV-622 branch September 26, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants