Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-763 : [Android] Remove functionality to solicit Play Store Reviews #1692

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Sep 28, 2022

馃摬 What

Remove functionality to solicit Play Store Reviews

馃 Why

The android app no longer prompts users to provide a play store review.

馃洜 How

Hide review app dialog behind feature flag android_hide_app_rating_dialog

馃憖 See

  • It cannot be tested on staging or other app build different from the release.

馃搵 QA

  • Nothing to check until the App is released/on internal test tracks

Story 馃摉

WEB-763

Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #1692 (5ddc420) into master (ceab1bc) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #1692   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         358     358           
  Lines       17928   17930    +2     
  Branches     2146    2147    +1     
======================================
- Misses      17928   17930    +2     
Impacted Files Coverage 螖
...a/com/kickstarter/libs/models/OptimizelyFeature.kt 0.00% <0.00%> (酶)
...java/com/kickstarter/viewmodels/ThanksViewModel.kt 0.00% <0.00%> (酶)

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@hadia hadia merged commit dbe30e6 into master Sep 28, 2022
@hadia hadia deleted the hadia/WEB-763_Android_Remove_functionality_to_solicit_Play_Store_Reviews branch September 28, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants