Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-747 #1693

Merged
merged 4 commits into from Sep 29, 2022
Merged

WEB-747 #1693

merged 4 commits into from Sep 29, 2022

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Sep 29, 2022

πŸ“² What

When a username was very long, badges were pushed off screen (see screenshots below)

πŸ›  How

  • Setting max number of lines to 1 and putting an ellipsis at the end of the username
  • Fixing the badges to the end of the comment UI

πŸ‘€ See

Before
Screenshot_20220921_152109

After (short and long usernames)
LongUsernameExample ShortUsernameExample youbadge

πŸ“‹ QA

  • Go to comments
  • Check that badges are fixed to the right side of the screen
  • Check that usernames truncate when they reach a badge or the end of the screen and end with an ellipsis.

Story πŸ“–

WEB-747: [Android] UI – User badges broken with long usernames

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1693 (3040945) into master (764e19a) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1693   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         358     358           
  Lines       17940   17940           
  Branches     2147    2147           
======================================
  Misses      17940   17940           

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leighdouglas leighdouglas merged commit fdeab63 into master Sep 29, 2022
@leighdouglas leighdouglas deleted the leigh/web-747-badge-bug branch September 29, 2022 19:51
Arkariang added a commit that referenced this pull request Oct 3, 2022
* 'master' of github.com:kickstarter/android-oss:
  WEB-747 (#1693)
  PAY-1988:  Fixed 3DS validation error (#1694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants