WEB-784 : [Android] Update video player for Project page To match the story player #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
hadia
requested review from
leighdouglas and
Arkariang
and removed request for
leighdouglas
hadia
changed the title
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Arkariang
added a commit
that referenced
this pull request
Nov 8, 2022
…tin/ntv-628 * 'master' of github.com:kickstarter/android-oss: WEB-784 : [Android] Update video player for Project page To match the story player (#1703)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Play the project video on the same page and when the user clicks full screen then move to landscape,To match the same user experience for the story tab when playing the video
🤔 Why
User complain about video player experience
https://kickstarter.slack.com/archives/CF2RAFWJW/p1666289253492129
🛠 How
Create video player View
Update project paged media header
When the Fullscreen clicked open video activity
if fullscreen clicked in the video activity play video in the same position
👀 See
| Before 🐛 |
device-2022-11-07-190129.mp4
| After 🦋 |
Untitled.mp4
📋 QA
Test project Media Header
Story 📖
https://kickstarter.atlassian.net/browse/WEB-784