New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAY-2067: Block links & pledge button when loading PaymentSheet #1707
Conversation
- Cannot press the link buttons while the create setup intent network request is place
…tin/PAY-2067 * 'master' of github.com:kickstarter/android-oss: hide backer tag when video clicked (#1706)
… into imartin/PAY-2067 * 'imartin/PAY-2067' of github.com:kickstarter/android-oss:
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
=========================================
Coverage 78.58% 78.59%
- Complexity 1949 1950 +1
=========================================
Files 359 359
Lines 17973 17973
Branches 2142 2142
=========================================
+ Hits 14124 14125 +1
Misses 2603 2603
+ Partials 1246 1245 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 😍
📲 What
When the user hits the New Payment method button, a network request takes place, but the user could still hit pledge, or some of the link to "Learn more about acountability", "Tems of use, Cookie policy" ... etc
Now the links are disabled alongside the pledge button until the PaymentSheet is presented
🤔 Why
👀 See
| Before 🐛 |
before.mp4
| After 🦋 |
after.mp4
| | |
📋 QA
Story 📖
PAY-2067