Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-2067: Block links & pledge button when loading PaymentSheet #1707

Merged
merged 8 commits into from Nov 16, 2022

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Nov 16, 2022

📲 What

When the user hits the New Payment method button, a network request takes place, but the user could still hit pledge, or some of the link to "Learn more about acountability", "Tems of use, Cookie policy" ... etc

Now the links are disabled alongside the pledge button until the PaymentSheet is presented

🤔 Why

  • Avoid the potentially presenting the paymentSheet in a wrong screen, or once the user has already pledge.

👀 See

| Before 🐛 |

before.mp4

| After 🦋 |

after.mp4
  • blocked interactions until the payment sheet is presented highlighted in the following screenshot:

Screenshot 2022-11-16 at 9 11 22 AM

| | |

📋 QA

  • Hit the New payment method button, and before the payment sheet is presented make sure pledge button is disabled alongside the links to "Learn more about acountability", "Tems of use, Cookie policy" ... etc

Story 📖

PAY-2067

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1707 (40b7ae8) into master (a6da72b) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 40b7ae8 differs from pull request most recent head 14fce05. Consider uploading reports for the commit 14fce05 to get more accurate results

@@            Coverage Diff            @@
##             master    #1707   +/-   ##
=========================================
  Coverage     78.58%   78.59%           
- Complexity     1949     1950    +1     
=========================================
  Files           359      359           
  Lines         17973    17973           
  Branches       2142     2142           
=========================================
+ Hits          14124    14125    +1     
  Misses         2603     2603           
+ Partials       1246     1245    -1     
Impacted Files Coverage Δ
...pp/src/main/java/com/kickstarter/models/Message.kt 81.63% <0.00%> (+2.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Arkariang Arkariang marked this pull request as ready for review November 16, 2022 17:23
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 😍

@Arkariang Arkariang merged commit 885e92a into master Nov 16, 2022
@Arkariang Arkariang deleted the imartin/PAY-2067 branch November 16, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants