Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-141 : New comments disappearing on pagination #1709

Merged
merged 9 commits into from Nov 29, 2022
Merged

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Nov 28, 2022

πŸ“² What

newly posted comments as soon as we load more pages of comments /Replies disappear
newly posted comments as soon as Pull to refresh duplicated

πŸ€” Why

Fix comments issue

πŸ›  How

Add a list of newly posted comments and append to the pagination source

πŸ‘€ See

Before

Uploading device-2022-11-28-215421.mp4…

After
https://user-images.githubusercontent.com/1075310/204365417-b34cfbd3-b643-44a2-bf12-c2764f7cb51f.mp4

πŸ“‹ QA

  1. Go to a project comments / Replies screen
  2. Post a comment
  3. Scroll down until more comments are loaded
  4. Scroll back up and look for your latest comment
  5. Pull to refresh

Story πŸ“–

https://kickstarter.atlassian.net/browse/NTV-141

Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #1709 (d704658) into master (dcfd6fa) will increase coverage by 0.02%.
The diff coverage is 85.10%.

@@             Coverage Diff              @@
##             master    #1709      +/-   ##
============================================
+ Coverage     78.58%   78.61%   +0.02%     
+ Complexity     1950     1949       -1     
============================================
  Files           359      359              
  Lines         17972    18013      +41     
  Branches       2142     2146       +4     
============================================
+ Hits          14124    14161      +37     
  Misses         2603     2603              
- Partials       1245     1249       +4     
Impacted Files Coverage Ξ”
...java/com/kickstarter/viewmodels/ThreadViewModel.kt 90.21% <83.33%> (-0.14%) ⬇️
...va/com/kickstarter/viewmodels/CommentsViewModel.kt 83.77% <86.20%> (+0.78%) ⬆️
...pp/src/main/java/com/kickstarter/models/Message.kt 79.59% <0.00%> (-2.05%) ⬇️

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @hadia !!! πŸ’–

@hadia hadia merged commit c2c6986 into master Nov 29, 2022
@hadia hadia deleted the hadia/NTV-141 branch November 29, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants