New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTV-141 : New comments disappearing on pagination #1709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
============================================
+ Coverage 78.58% 78.61% +0.02%
+ Complexity 1950 1949 -1
============================================
Files 359 359
Lines 17972 18013 +41
Branches 2142 2146 +4
============================================
+ Hits 14124 14161 +37
Misses 2603 2603
- Partials 1245 1249 +4
π£ Weβre building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Arkariang
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @hadia !!! π
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π² What
newly posted comments as soon as we load more pages of comments /Replies disappear
newly posted comments as soon as Pull to refresh duplicated
π€ Why
Fix comments issue
π How
Add a list of newly posted comments and append to the pagination source
π See
Before
Uploading device-2022-11-28-215421.mp4β¦
After
https://user-images.githubusercontent.com/1075310/204365417-b34cfbd3-b643-44a2-bf12-c2764f7cb51f.mp4
π QA
Story π
https://kickstarter.atlassian.net/browse/NTV-141