PAY-2080: Retry pledge after error with PaymentSheet

[Arkariang]

📲 What

Several points in the PR:

• 1 - Fix for crash with exception Fatal Exception: java.lang.IllegalArgumentException: Invalid Setup Intent client secret: ... discovered during QA party for Checkout flows with PaymentSheet. Firebase report
  Refined a bit the user facing error messages for this point with, instead of presenting the generic "Something went wrong" message, now the Stripe error localized message is displayed to the user.
• 2 - Discovered TransactionTooLargeException for certain projects when triggering 3DS flow after adding payment method using PaymentSheet Firebase report
• Updated Stripes library to latest version

🛠 How

⚠️ (use debug build to have complete logs).
This section is gonna described mainly those steps to identify the root cause behind #2. In order to debug an identify the TransactionTooLargeException a key tool has been https://github.com/guardian/toolargetool, is a debug tool so no trace of it on the PR.

First taking a closer look into the logcat trace of the error, on the warnings you can see :

This warning trace indicates fragments presented and their size, as you can see two of the are taking up much more memory than they should, and are considerably bigger that the rest one fragment with [size=143456] and [size=431628] those hexadecimals identifiers can be traced back to the KS fragments by filtering mode the onCreate logs (the screenshot is just to showcase how to filter in logcat, it does not match the with the execution of the previous exception)

At this point the guilty intents have been identified in your trace and those two were BackingAddOnsFragment and PledgeFragment, the intents for launching those two fragments were taking more than 100KB each ...

Now if you add toolargetool to your build, and have breakpoints on those functions starting the BackingAddOnsFragment and PledgeFragment you will be able to evaluate in real time the size of the intent by using toolargetool method bundleBreakdown

BEFORE: 140KB was the size for the the BackingAddOnsFragment bundle

NOW: 3.6 is the size for the BackingAddOnsFragment bundle

The solution has been reducing the project fields to only those mandatory to be able to operate the user journey from the moment a reward is picked, please take a look into Project.reduce() extension function to have more details about which ones are those mandatory fields.

Also taken the chance to review the RX subscriptions and tied those who weren't before to the lifecycle in all the user journey since the point a reward is picked, and reduced to only the project.slug the bundles for ProjectActivity, UpdateActivity.

👀 See

| Before 🐛 |

before.mp4

| After 🦋 |

after.mp4

| | |

📋 QA

For QA #1 :

• Pledge to a project, adding a new payment method during checkout, introduce the payment details, and before hitting "Continue CTA" on the PaymentSheet turn on airplane mode, or loose connectivity, hit now the "Continue CTA" on the PaymentSheet. You should see an error message and the payment method not added to the UI. Once you recover connectivity, you should be able to add the payment method again and pledge.
• Pledge to a project, adding a new payment method during checkout, a 3DS one, you can use for example 4000 0000 0000 3220, once the 3DS flow is presented fail it, you should see a message like the screenshot below, and the payment method not visible on the UI. After that you should be able to pledge or add a new payment method as usual.
  

For QA #2 :

• Go to the project https://staging.kickstarter.com/projects/patshand/destiny-ny-volume-six-volumes-1-6-available and try to pledge , adding a new payment method during checkout, a 3DS one, you can use for example 4000 0000 0000 3220. You should be able to complete the 3DS challenge without any crash as shown on the AFTER video

Story 📖

NTV-2080

[codecov]

Codecov Report

Merging #1710 (864a90f) into master (c2c6986) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1710      +/-   ##
============================================
+ Coverage     78.62%   78.64%   +0.02%     
- Complexity     1950     1952       +2     
============================================
  Files           359      359              
  Lines         18013    18031      +18     
  Branches       2146     2146              
============================================
+ Hits          14162    14180      +18     
  Misses         2603     2603              
  Partials       1248     1248              

Impacted Files	Coverage Δ
...om/kickstarter/libs/utils/extensions/ProjectExt.kt	77.22% <100.00%> (+4.93%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[leighdouglas]

great! Lgtm!