Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-jira]: Update String translation for facebook deprecation #1714

Merged
merged 3 commits into from Dec 7, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Dec 6, 2022

📲 What

Replace strings with translated ones

🤔 Why

to release feature

👀 See

Screenshot_20221206_221028
Screenshot_20221206_221005
Screenshot_20221206_213733

Story 📖

no-Jira

Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1714 (7be2a99) into master (37e2647) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@             Coverage Diff              @@
##             master    #1714      +/-   ##
============================================
- Coverage     78.63%   78.62%   -0.01%     
+ Complexity     1951     1950       -1     
============================================
  Files           359      359              
  Lines         18032    18036       +4     
  Branches       2146     2147       +1     
============================================
+ Hits          14179    14181       +2     
  Misses         2604     2604              
- Partials       1249     1251       +2     
Impacted Files Coverage Δ
...com/kickstarter/ui/activities/LoginToutActivity.kt 100.00% <ø> (ø)
.../java/com/kickstarter/viewmodels/LoginViewModel.kt 92.80% <87.50%> (-0.58%) ⬇️
...c/main/java/com/kickstarter/ui/data/LoginReason.kt 83.33% <100.00%> (+1.51%) ⬆️
...om/kickstarter/ui/data/ResetPasswordScreenState.kt 100.00% <100.00%> (ø)
...pp/src/main/java/com/kickstarter/models/Message.kt 79.59% <0.00%> (-2.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hadia hadia merged commit 358fa5a into master Dec 7, 2022
@hadia hadia deleted the hadia/update_facebook_deperaction_translation branch December 7, 2022 14:28
Arkariang added a commit that referenced this pull request Dec 8, 2022
…/android-oss into release-3.7.0

* 'release-3.7.0' of github.com:kickstarter/android-oss:

* 'master' of github.com:kickstarter/android-oss:
  NTV-637: Messages screen unable to load more messages (#1716)
  NTV-364: Creator dashboard not loading for release 3.7.0(#1715)
  [no-jira]: Update String translation for facebook deprecation (#1714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants