facepile ( •_•) ( •_•)>⌐■-■ (⌐■_■) #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evice and ", " in tests....
swoopej
approved these changes
Dec 1, 2017
| this.friendAvatarUrl2.assertValues(project.friends().get(1).avatar().small()); | ||
| this.friendAvatarUrl3.assertValues(project.friends().get(2).avatar().small()); | ||
| this.friendAvatar2IsHidden.assertValue(false); | ||
| this.friendAvatar3IsHidden.assertValue(false); |
There was a problem hiding this comment.
should we have a test for _withNoFriends? :foreveralone:
There was a problem hiding this comment.
I think testEmitsFriendBackingViewIsHidden test handles that case! 🕵️♀️
|
|
||
| return ksString.format("discovery_baseball_card_social_friends_are_backers", friends.size(), | ||
| return ksString.format("discovery_baseball_card_social_friends_are_backers", friends.size() == 3 ? friends.size() - 1 : friends.size(), |
There was a problem hiding this comment.
yeah this is all a bit gnarly but it makes sense! If I have any refactoring ideas I'll chime in.
luoser
reviewed
Dec 4, 2017
| final String friendName = friends.size() >= 1 ? friends.get(0).name() : ""; | ||
| final String secondFriendName = friends.size() >= 2 ? friends.get(1).name() : ""; | ||
| final String remainingCount = NumberUtils.format(Math.max(0, friends.size() - 2)); | ||
| public static @NonNull String projectCardFriendNamepile(final Context context, final @NonNull List<User> friends, final @NonNull KSString ksString) { |
| final String friendName; | ||
| if (friends.size() < 3) { | ||
| friendName = friends.size() >= 1 ? friends.get(0).name() : ""; | ||
| } else { |
There was a problem hiding this comment.
this logic makes sense, but is a little hard to read through. maybe it'd be helpful to leave a lil comment here with an example of what friendName would be set here
| @@ -118,10 +120,30 @@ public ProjectCardViewHolder(final @NonNull View view, final @NonNull Delegate d | |||
| .compose(observeForUI()) | |||
| .subscribe(ViewUtils.setGone(this.featuredViewGroup)); | |||
|
|
|||
| this.viewModel.outputs.friendAvatarUrl() | |||
| this.viewModel.outputs.friendAvatar2IsHidden() | |||
There was a problem hiding this comment.
can rename these outputs from IsHidden to IsGone to more properly reflect what's happening in the view!
| @@ -282,10 +304,10 @@ private void setDeadlineCountdownText(final @NonNull Project project) { | |||
| this.deadlineCountdownUnitTextView.setText(ProjectUtils.deadlineCountdownDetail(project, context(), this.ksString)); | |||
| } | |||
|
|
|||
| private void setFriendAvatarUrl(final @NonNull String avatarUrl) { | |||
| private void setFriendAvatarUrl(final @NonNull String avatarUrl, final @NonNull ImageView imageView) { | |||
| android:layout_gravity="center_vertical" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| tools:text="Dancing Hot Dog, Frank, and 1 more are backers." /> |
|
lgtm! |
|
👍 comments are helpful! |
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* Facepile and new namepile logic with tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Implementing ✨ facepile ✨ designs showing up to 3 friends' names and avatars.
SocialUtilsgot hairy. Open to any and all suggestions.who is she