toolbar refresh #185
Merged
toolbar refresh #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoser
approved these changes
Dec 4, 2017
| public AlphaBehavior() { | ||
| } | ||
|
|
||
| public AlphaBehavior(final Context context, final AttributeSet attrs) { |
There was a problem hiding this comment.
nice use of a custom view class!!!!!!! only comment here are to annotate the method params @NonNull
| @@ -2,6 +2,5 @@ | |||
| <selector xmlns:android="http://schemas.android.com/apk/res/android"> | |||
| <item android:drawable="@color/dark_gray_click" android:state_focused="true" /> | |||
| <item android:drawable="@color/dark_gray_click" android:state_pressed="true" /> | |||
| <item android:drawable="@color/dark_gray_click" android:state_selected="true" /> | |||
There was a problem hiding this comment.
aha this was showing the awkward selected state? thanks!
| layout="@layout/horizontal_line_1dp_view" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| app:layout_behavior="com.kickstarter.ui.toolbars.AlphaBehavior" /> |
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:fitsSystemWindows="true"> | ||
|
|
||
| <android.support.design.widget.AppBarLayout |
There was a problem hiding this comment.
thanks for cleaning up this unneeded AppBarLayout!
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* toolbar alpha when scrolling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Started with discovery as a first pass since it's most visible.
AppBarLayoutno longer has elevation, now has a divider whose alpha is based on how much the user has scrolled. The toolbar is only expanded when at the top of the list.For fun, I got rid of the awkward selected state in the toolbar on pre 21 devices.
who is she