MBL-1053: Identify if https links in messages are KSR links #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1917 +/- ##
=========================================
Coverage 74.29% 74.29%
Complexity 1963 1963
=========================================
Files 337 337
Lines 19679 19679
Branches 2730 2730
=========================================
Hits 14620 14620
Misses 3491 3491
Partials 1568 1568 ☔ View full report in Codecov by Sentry. |
mtgriego
approved these changes
Dec 11, 2023
| @@ -48,7 +48,7 @@ interface MessageHolderViewModel { | |||
| ActivityViewModel<MessageViewHolder?>(environment), | |||
| Inputs, | |||
| Outputs { | |||
| private val currentUser: CurrentUserType? | |||
| private val currentUser: CurrentUserTypeV2? | |||
There was a problem hiding this comment.
very minor, but currentUser cant be null (due to requireNotNull(*)) so it doesn't need to be nullable here
There was a problem hiding this comment.
I'll fix in a subsequent PR! Thanks!
Arkariang
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Goal is to validate links sent in messages by creators to open app links in-app where applicable.
🤔 Why
Previously, urls sent by creators would always open an external browser. Now, when it is a kickstarter link, it will open in app. All other links will continue to go to an external browser.
🛠 How
👀 See
messages-link-validation.mp4
📋 QA
Story 📖
MBL-1053: Identify if https links in messages are KSR links