[MBL-1127] Dark mode #1922
Merged
[MBL-1127] Dark mode #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…existing screens for dark mode in compose where needed
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1922 +/- ##
============================================
- Coverage 74.23% 74.09% -0.14%
Complexity 1967 1967
============================================
Files 336 336
Lines 19597 19634 +37
Branches 2711 2716 +5
============================================
Hits 14547 14547
- Misses 3466 3499 +33
- Partials 1584 1588 +4 ☔ View full report in Codecov by Sentry. |
…, make discovery hamburger menu visible in dark mode
Arkariang
reviewed
Jan 10, 2024
| @@ -62,6 +63,8 @@ class CreatePasswordActivity : AppCompatActivity() { | |||
| AppThemes.LIGHT.ordinal -> false | |||
| else -> false | |||
| } | |||
| } else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { | |||
There was a problem hiding this comment.
[not mandatory], but we could try to move all theme related logic to the composable KickstarterApp, trying to avoid having to repeat in every single screen the theming setup.
There was a problem hiding this comment.
thats a good idea, just not sure how much access the kickstarter app has to builds and stuff, but ill play around with that, would save a lot of time
Arkariang
previously approved these changes
Jan 10, 2024
Arkariang
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Add forced dark mode to the app so the app matches the system theme and shows dark mode content
🤔 Why
Dark mode is one of the most requested features for android
🛠 How
Added a new theme for v29+ that includes
<item name="isLightTheme">true</item>which forces the app into a dark theme. This is not a permanent fix, but a quick win
👀 See
(https://github.com/kickstarter/android-oss/assets/7563288/be3814b0-2d86-4fe0-b4e5-3580d6961574)
📋 QA
Go through every screen in the app and confirm it looks good in both light and dark modes
NOTE: The help page webviews (privacy policy, terms etc) will only appear in light mode
Story 📖
MBL-1127