MBL-810: DeeplinkViewModel.kt to Jetpack ViewModel and RxJava2.2 #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighdouglas
requested review from
Arkariang,
mtgriego and
ycheng-kickstarter
leighdouglas
changed the title
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1924 +/- ##
============================================
- Coverage 74.27% 74.23% -0.05%
- Complexity 1965 1967 +2
============================================
Files 336 336
Lines 19614 19597 -17
Branches 2711 2711
============================================
- Hits 14568 14547 -21
+ Misses 3478 3466 -12
- Partials 1568 1584 +16 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Update Deeplink view model to rxjava 2
🤔 Why
Technical Details
👀 See
no user-facing changes
📋 QA
Might require some additional testing, but essentially making sure all of the deeplinks listed as working in this doc are still working - 🤖 State of Deeplinks on Android
Story 📖
MBL-810: DeeplinkViewModel.kt to Jetpack ViewModel and RxJava2.2