Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-806] Update (Remove) WebViewViewModel #1925

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Jan 9, 2024

📲 What

Remove the viewmodel for this activity, it wasnt doing anything

🤔 Why

RX1 is old and busted, making room for the new hotness

🛠 How

✂️

📋 QA

Test pages that are currently web view controlled (creator bio, updates, help, etc)

Story 📖

MBL-806

@mtgriego mtgriego self-assigned this Jan 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10a75aa) 74.27% compared to head (8c247c8) 74.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1925      +/-   ##
============================================
- Coverage     74.27%   74.25%   -0.03%     
  Complexity     1963     1963              
============================================
  Files           337      336       -1     
  Lines         19672    19653      -19     
  Branches       2718     2718              
============================================
- Hits          14612    14593      -19     
  Misses         3490     3490              
  Partials       1570     1570              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtgriego mtgriego marked this pull request as ready for review January 9, 2024 19:37
@mtgriego mtgriego merged commit 69c7220 into master Jan 9, 2024
3 checks passed
@mtgriego mtgriego deleted the mgriego/MBL-806 branch January 9, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants