Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RepliesStatusCellViewHolderViewmodel to RX2 #1928

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Jan 10, 2024

📲 What

Update RepliesStatusCellViewHolderViewmodel to RX2

🤔 Why

Updating all the things to RX2

📋 QA

Make sure teh messages page/thread page works as expected

Story 📖

MBL-792

@mtgriego mtgriego self-assigned this Jan 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ac0203c) 74.09% compared to head (4c9f94b) 74.07%.
Report is 1 commits behind head on master.

Files Patch % Lines
...s/rx/transformers/IncrementalCountTransformerV2.kt 57.14% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1928      +/-   ##
============================================
- Coverage     74.09%   74.07%   -0.02%     
- Complexity     1967     1968       +1     
============================================
  Files           336      337       +1     
  Lines         19634    19642       +8     
  Branches       2716     2716              
============================================
+ Hits          14547    14549       +2     
- Misses         3499     3506       +7     
+ Partials       1588     1587       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtgriego mtgriego marked this pull request as ready for review January 10, 2024 19:30
@mtgriego mtgriego merged commit a20e8f9 into master Jan 16, 2024
3 checks passed
@mtgriego mtgriego deleted the mgriego/MBL-792 branch January 16, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants