MBL-905: Remove Use of IA tab feature flag #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
============================================
- Coverage 73.95% 73.93% -0.02%
- Complexity 1965 1969 +4
============================================
Files 337 338 +1
Lines 19693 19694 +1
Branches 2738 2739 +1
============================================
- Hits 14563 14560 -3
Misses 3523 3523
- Partials 1607 1611 +4 ☔ View full report in Codecov by Sentry. |
Arkariang
commented
Jan 17, 2024
| @@ -536,66 +529,21 @@ class ProjectPageViewModelTest : KSRobolectricTestCase() { | |||
| } | |||
|
|
|||
| @Test | |||
| fun testUIOutputs_whenFetchProjectWithAIDisclosureAndFFOFF_WithoutEnVCommitment() { | |||
There was a problem hiding this comment.
Deleted feature flag off tests
Arkariang
commented
Jan 17, 2024
| @@ -498,28 +498,21 @@ class ProjectPageViewModelTest : KSRobolectricTestCase() { | |||
| } | |||
|
|
|||
| @Test | |||
| fun testUIOutputs_whenFetchProjectWithAIDisclosureAndFFOn_WithoutEnVCommitment() { | |||
There was a problem hiding this comment.
Modified feature flag On tests, and renamed
Arkariang
requested review from
leighdouglas,
mtgriego and
ycheng-kickstarter
and removed request for
leighdouglas
mtgriego
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
AiDisclosuremodel with ID available, but the rest of the fields are empty if not UI usage on the project, as before we were considering a project did not used AI ifAiDisclosurewas null🤔 Why
| | |
📋 QA
Story 📖
https://kickstarter.atlassian.net/browse/MBL-905