Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-782] Update NotificationActivity to RX2 #1933

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Jan 17, 2024

📲 What

Update NotificationActivity to RX2

🤔 Why

Getting close y'all

🛠 How

🧠

📋 QA

Make sure the toggling of notification settings still works, even after closing the app

Story 📖

MBL-782

@mtgriego mtgriego self-assigned this Jan 17, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (6c857bd) 74.04% compared to head (456b227) 73.94%.

Files Patch % Lines
...m/kickstarter/viewmodels/NotificationsViewModel.kt 69.56% 6 Missing and 22 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1933      +/-   ##
============================================
- Coverage     74.04%   73.94%   -0.11%     
+ Complexity     1968     1964       -4     
============================================
  Files           337      337              
  Lines         19649    19693      +44     
  Branches       2718     2738      +20     
============================================
+ Hits          14550    14562      +12     
- Misses         3512     3523      +11     
- Partials       1587     1608      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtgriego mtgriego marked this pull request as ready for review January 17, 2024 22:09
@mtgriego mtgriego merged commit fe81cd6 into master Jan 17, 2024
3 checks passed
@mtgriego mtgriego deleted the mgriego/MBL-782 branch January 17, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants