Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1169: Redirection step #1947

Merged
merged 2 commits into from
Feb 13, 2024
Merged

MBL-1169: Redirection step #1947

merged 2 commits into from
Feb 13, 2024

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Feb 12, 2024

馃摬 What

  • On AuthorizationStep the authorization URL is generated adding PKCE parameters to the url
  • On redirectionStep an appplink redirects back to the app, so far the redirection only contains code, not ready yet to call the token endpoint (WIP) on the backend side.

馃 Why

  • OAuth 2.0 on the apps

馃洜 How

  • The VM now receives an Intent is able to build the authorization URL is staging and production on the AuthorizationStep
  • the VM now receives an Intent and is able to collect from it the code that will be used later on to call the Token endpoint.
  • OAuthActivity registers the redirectionUrl deeplink.
  • Added tests
  • Added an Interface wrapper on CodeVerifier to be able to mock it on tests.

馃憖 See

  • Chroma tab should be able to load AuthorizationUrl
  • Once the user has introduced email + password the redirection back to app enters in place back to a currently empty OAuthActivity
LogIn.mp4

| | |

馃搵 QA

  • Turn the ff on, try to log in, the ChromeTab will load a formulary, once successful user + password introduced the user is redirected back to the app, to an empty OAuthActivity for now.
  • You can also take a look at logcat filtering by package:mine level:debug OAuth, and look for the debug messages showing the AuthorizationStep + url to load, and the TokenRetrieveStep + code
Screenshot 2024-02-11 at 3 12 58鈥疨M

Story 馃摉

MBL-1168

@Arkariang Arkariang self-assigned this Feb 12, 2024
@Arkariang Arkariang added the OAuth 2.0 Tied to epic https://kickstarter.atlassian.net/browse/MBL-1108 label Feb 12, 2024
@Arkariang Arkariang merged commit 735c1f7 into master Feb 13, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1169 branch February 13, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OAuth 2.0 Tied to epic https://kickstarter.atlassian.net/browse/MBL-1108
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants