Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1071 Add link to Kickstarter campaign from messages #1950

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

ycheng-kickstarter
Copy link
Contributor

📲 What

In Messages view, allow user to click on project name to navigate to project page

🤔 Why

We received a feature request on Android (from app store reviews) about wanting to be able to click on the KSR campaign from Messages.

🛠 How

Added a test too

👀 See

The touch target size is shown in blue:
Screenshot 2024-02-13 at 3 30 12 PM

📋 QA

Go to your messages. Click on a message. Click on the project name to navigate to the project page.

Story 📖

https://kickstarter.atlassian.net/browse/MBL-1071

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b7938e) 73.93% compared to head (632ae06) 73.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1950      +/-   ##
============================================
+ Coverage     73.93%   73.95%   +0.02%     
+ Complexity     1977     1976       -1     
============================================
  Files           343      343              
  Lines         19814    19823       +9     
  Branches       2757     2757              
============================================
+ Hits          14649    14660      +11     
+ Misses         3550     3548       -2     
  Partials       1615     1615              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ycheng-kickstarter ycheng-kickstarter merged commit fb9e580 into master Feb 14, 2024
3 checks passed
@ycheng-kickstarter ycheng-kickstarter deleted the MBL-1071-click-project-messages branch February 14, 2024 01:10
@ycheng-kickstarter ycheng-kickstarter self-assigned this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants