MBL-1182: Crash from rx chain returning null in TwoFactorViewModel.kt #1951

leighdouglas · 2024-02-15T20:22:34Z

📲 What

Cleanup for TwoFactorViewModel to fix this crash

Knockin out bugs

Can't easily reproduce but:

Made the intent passed into the viewmodel nonnull
return an empty string if password or email from intent is null - if an empty string is passed down because there is no email or password in the intent, it will not allow login with an error message. doing the normal filtering for null values will cause there to be no reaction when the user taps submit and there wont be an error message. I figured empty string route is better

no user facing changes

leighdouglas added 2 commits February 15, 2024 14:00

cleanup null checks

f489bc2

linter

d6b80f0

leighdouglas requested review from Arkariang, mtgriego and ycheng-kickstarter February 15, 2024 20:22

mtgriego approved these changes Feb 15, 2024

View reviewed changes

ycheng-kickstarter approved these changes Feb 15, 2024

View reviewed changes

leighdouglas merged commit 7d33deb into master Feb 15, 2024
3 checks passed

leighdouglas deleted the leigh/mbl-1182 branch February 15, 2024 20:55