Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1165] Add Query and Mutation for Checkout Flow #1953

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Feb 20, 2024

📲 What

Added the last couple query and mutations for the post campaign checkout flow, also a renaming of a variable

🤔 Why

They are needed for the flow for validations and actually doing the backing

🛠 How

Tested the mutation and query in staging, put them in the app and in the Apollo Client

📋 QA

Not implemented yet

Story 📖

MBL-1165

@mtgriego mtgriego self-assigned this Feb 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8207db8) 73.95% compared to head (a52f31a) 73.94%.

Files Patch % Lines
...com/kickstarter/models/CreatePaymentIntentInput.kt 0.00% 1 Missing ⚠️
...om/kickstarter/models/PaymentValidationResponse.kt 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1953      +/-   ##
============================================
- Coverage     73.95%   73.94%   -0.01%     
+ Complexity     1977     1976       -1     
============================================
  Files           343      344       +1     
  Lines         19818    19819       +1     
  Branches       2759     2759              
============================================
- Hits          14657    14656       -1     
- Misses         3545     3546       +1     
- Partials       1616     1617       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtgriego mtgriego marked this pull request as ready for review February 21, 2024 00:19
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🎉

@mtgriego mtgriego merged commit 81d14a6 into master Feb 21, 2024
3 checks passed
@mtgriego mtgriego deleted the mgriego/MBL-1165 branch February 21, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants