Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1172: Remove Perimeter X #1955

Merged
merged 6 commits into from
Feb 26, 2024
Merged

MBL-1172: Remove Perimeter X #1955

merged 6 commits into from
Feb 26, 2024

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Feb 22, 2024

📲 What

Remove PerimeterX dependency

🤔 Why

Contract ending

🛠 How

  • Removed dependecy from gradle, client wrapper and tests

👀 See

No user facing changes
| | |

📋 QA

No user facing changes, but you can take a look at the network profiler -> requests and see that the perimeterX header has been removed

newEndpointRequestBody

Story 📖

MBL-1172

@Arkariang Arkariang added the OAuth 2.0 Tied to epic https://kickstarter.atlassian.net/browse/MBL-1108 label Feb 22, 2024
mtgriego
mtgriego previously approved these changes Feb 22, 2024
@mtgriego
Copy link
Contributor

There still seem to be at least one reference to perim x in the KSWebViewClient and the currentUser in ApplicationModule ApiRequestInterceptor seems to be the wrong type

@Arkariang
Copy link
Contributor Author

Arkariang commented Feb 25, 2024

@mtgriego Yes! The PR on native-secrets adreses the changes on KSWebViewClient.java https://github.com/kickstarter/native-secrets/pull/95 , once that PR is merged, the build will succeed once retrigered, as it will use the latest version on native-secrets.
CurrentUserType updated! nice catch!

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽 👏🏽 👏🏽

@Arkariang Arkariang merged commit 3b8e813 into master Feb 26, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1172 branch April 1, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OAuth 2.0 Tied to epic https://kickstarter.atlassian.net/browse/MBL-1108
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants