-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBL-1213: Stop sending token as query param for V1, send the token as basic auth header #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tin/mbl-1213 # Conflicts: # app/src/main/java/com/kickstarter/services/interceptors/ApiRequestInterceptor.kt
- Renamed LoginUseCaseMethod
Arkariang
changed the title
Imartin/mbl 1213
MBL-1213: Stop sending token as query param for V1, send the token as basic auth header
Feb 27, 2024
Arkariang
added
the
OAuth 2.0
Tied to epic https://kickstarter.atlassian.net/browse/MBL-1108
label
Feb 27, 2024
Arkariang
requested review from
mtgriego,
ycheng-kickstarter and
leighdouglas
February 27, 2024 15:50
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1958 +/- ##
============================================
+ Coverage 73.85% 73.87% +0.02%
- Complexity 1975 1979 +4
============================================
Files 346 347 +1
Lines 19870 19881 +11
Branches 2758 2758
============================================
+ Hits 14674 14688 +14
+ Misses 3582 3578 -4
- Partials 1614 1615 +1 ☔ View full report in Codecov by Sentry. |
ycheng-kickstarter
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
/xauth/access_token
returneduser
andtoken
as response, reason whyCurrentUser
login method required both parameters, with the new endpoint/v1/oauth/authorizations/exchange
we first obtain thetoken
and later on request for/v1/users/self
.CurrentUser
,CurrentUserV2
andLoginUserCase
to handle separatelytoken
anduser
🤔 Why
👀 See
| Before 🐛 |
|After 🦋 |
| | |
📋 QA
No user facing changes for this one, you should be able to navigate/ login out with ffon and ffoff as usual.
But you can take a look at the network inspector, check for V1 calls and see how there is no token as query param :)
Story 📖
MBL-1213