Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1232: Unify and verify sign up/log in buttons #1961

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Feb 28, 2024

📲 What

  • Unified buttons, Log in with email and Sign up now happen on the web formulary after OAuth2.0

👀 See

| Before 🐛 | After 🦋 |
FF ON
Screenshot 2024-02-28 at 2 17 39 PM

FF OFF
Screenshot 2024-02-28 at 2 17 56 PM

| | |

📋 QA

  • With feature flag on, you will see only one button for sign up or log in
  • With feature flag off, you will see the old flow with two separated buttons to log in with email and sign up

Story 📖

MBL-1232

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.88%. Comparing base (925af00) to head (033e40f).

Files Patch % Lines
...ter/ui/activities/compose/login/LoginToutScreen.kt 86.95% 2 Missing and 1 partial ⚠️
...a/com/kickstarter/viewmodels/LoginToutViewModel.kt 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1961   +/-   ##
=========================================
  Coverage     73.87%   73.88%           
  Complexity     1979     1979           
=========================================
  Files           347      347           
  Lines         19881    19886    +5     
  Branches       2758     2755    -3     
=========================================
+ Hits          14688    14692    +4     
- Misses         3578     3580    +2     
+ Partials       1615     1614    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang self-assigned this Feb 28, 2024
@Arkariang Arkariang added the OAuth 2.0 Tied to epic https://kickstarter.atlassian.net/browse/MBL-1108 label Feb 28, 2024
@Arkariang Arkariang changed the title Imartin/mbl 1232 MBL-1232: Unify and verify sign up/log in buttons Feb 28, 2024
@Arkariang Arkariang marked this pull request as ready for review February 28, 2024 17:35
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Arkariang Arkariang merged commit 216632b into master Feb 29, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1232 branch February 29, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OAuth 2.0 Tied to epic https://kickstarter.atlassian.net/browse/MBL-1108
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants